[coreboot-gerrit] Change in coreboot[master]: [Not For Merge] nb/intel/i945: Remove unused #define REFRESH_*

HAOUAS Elyes (Code Review) gerrit at coreboot.org
Mon Mar 27 21:43:41 CEST 2017


HAOUAS Elyes has uploaded a new change for review. ( https://review.coreboot.org/19016 )

Change subject: [Not For Merge] nb/intel/i945: Remove unused #define REFRESH_*
......................................................................

[Not For Merge] nb/intel/i945: Remove unused #define REFRESH_*

REFRESH_15_6US is not used.
We probably do not need to define REFRESH_7_8US and REFRESH_15_6US

Change-Id: I70d5437face1a3ff4cacda4cb3f9a67d2ca4c403
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/northbridge/intel/i945/raminit.c
1 file changed, 1 insertion(+), 6 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/19016/1

diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c
index 0499b48..900c180 100644
--- a/src/northbridge/intel/i945/raminit.c
+++ b/src/northbridge/intel/i945/raminit.c
@@ -1702,16 +1702,11 @@
 	}
 }
 
-#define REFRESH_7_8US	1
-#define REFRESH_15_6US	0
 static void sdram_program_refresh_rate(struct sys_info *sysinfo)
 {
 	u32 reg32;
 
-	if (sysinfo->refresh == REFRESH_7_8US)
-		reg32 = (2 << 8); /* Refresh enabled at 7.8us */
-	else
-		reg32 = (1 << 8); /* Refresh enabled at 15.6us */
+	reg32 = (sysinfo->refresh + 1) << 8;
 
 	MCHBAR32(C0DRC0) &= ~(7 << 8);
 	MCHBAR32(C0DRC0) |= reg32;

-- 
To view, visit https://review.coreboot.org/19016
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I70d5437face1a3ff4cacda4cb3f9a67d2ca4c403
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>



More information about the coreboot-gerrit mailing list