[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Clean up serialio header file.

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19001 )

Change subject: soc/intel/skylake: Clean up serialio header file.
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/19001/2/src/soc/intel/skylake/include/soc/i2c.h
File src/soc/intel/skylake/include/soc/i2c.h:

PS2, Line 31: #define I2C_RESET_EN	(3 << 0)
this name doesn't goes well with bit field. and why we need to use <<0 , its 0-1 indeed.


https://review.coreboot.org/#/c/19001/2/src/soc/intel/skylake/include/soc/uart.h
File src/soc/intel/skylake/include/soc/uart.h:

PS2, Line 18: 
            : #define UART_CLK	0x200
            : #define UART_RESET	0x204
            : 
            : #define UART_CLK_UPDATE	(1 << 31)
            : #define UART_CLK_EN	(1 << 0)
            : #define UART_RESET_EN	(3 << 0)
            : #define UART_RESET_DMA_EN	(1 << 2)
i think you misunderstood.
i meant, club registers and its own big definition together 

example: 
#define reg 1
#define   reg_bit 1

#define reg_2 2
#define   reg_2_bit 2

Then you define macro those are not big definition but some value macro.


-- 
To view, visit https://review.coreboot.org/19001
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I881da01be8191270d9505737f68a6d2d8cd8cc69
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes