[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Add Intel common UART code

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/18952 )

Change subject: soc/intel/common/block: Add Intel common UART code
......................................................................


Patch Set 4:

(3 comments)

https://review.coreboot.org/#/c/18952/4/src/soc/intel/common/block/include/intelblocks/uart.h
File src/soc/intel/common/block/include/intelblocks/uart.h:

PS4, Line 19: #include <arch/io.h>
why we need this here?


https://review.coreboot.org/#/c/18952/4/src/soc/intel/common/block/uart/uart.c
File src/soc/intel/common/block/uart/uart.c:

Line 18: #include <soc/uart.h>
u need io.h here


PS4, Line 36: 	clk_sel = UART_CLK_DIV_N(UART_CLK_N_VAL) | UART_CLK_DIV_M(UART_CLK_M_VAL);
>80


-- 
To view, visit https://review.coreboot.org/18952
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3843fac88cfb7bbb405be50d69f555b274f0d72a
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes