[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Clean up serialio header file.

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19001 )

Change subject: soc/intel/skylake: Clean up serialio header file.
......................................................................


Patch Set 1:

(6 comments)

https://review.coreboot.org/#/c/19001/1/src/soc/intel/skylake/bootblock/i2c.c
File src/soc/intel/skylake/bootblock/i2c.c:

PS1, Line 25: #include <soc/i2c.h>
watch out for alphabetic order


https://review.coreboot.org/#/c/19001/1/src/soc/intel/skylake/include/soc/i2c.h
File src/soc/intel/skylake/include/soc/i2c.h:

PS1, Line 19: #define I2C_RESET	0x204
I2C_SOFT_RESET


PS1, Line 20: #define I2C_RESET_EN	(3 << 0)
what is this 3 mean?
mention bit field names
00 = I2C Host Controller is in reset (Reset Asserted)
01 = Reserved
10 = Reserved
11 = I2C Host Controller is NOT at reset (Reset Released)


https://review.coreboot.org/#/c/19001/1/src/soc/intel/skylake/include/soc/uart.h
File src/soc/intel/skylake/include/soc/uart.h:

PS1, Line 22: #define UART_CLK_N_VAL	0xc35
            : #define UART_CLK_M_VAL	0x30
move this macros below, lets have all bit definition intact


PS1, Line 27: #define UART_RESET	0x204
-same


PS1, Line 28: #define UART_RESET_EN	(3 << 0)
-same


-- 
To view, visit https://review.coreboot.org/19001
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I881da01be8191270d9505737f68a6d2d8cd8cc69
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes