[coreboot-gerrit] Change in coreboot[master]: siemens/mc_apl1: Adjust gpio settings

Werner Zeh (Code Review) gerrit at coreboot.org
Mon Mar 27 14:28:17 CEST 2017


Werner Zeh has posted comments on this change. ( https://review.coreboot.org/18995 )

Change subject: siemens/mc_apl1: Adjust gpio settings
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/18995/1/src/mainboard/siemens/mc_apl1/romstage.c
File src/mainboard/siemens/mc_apl1/romstage.c:

PS1, Line 17: #include <console/console.h>
You can drop this include as there is no printk() usage in this file.


-- 
To view, visit https://review.coreboot.org/18995
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f440e863c2e6f59298c500ac5aefa3b7386bcdf
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list