[coreboot-gerrit] Change in coreboot[master]: Mainboard: Add Asrock G41C-GS

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18993 )

Change subject: Mainboard: Add Asrock G41C-GS
......................................................................


Patch Set 3:

(1 comment)

I do not own this board. Did this port based on some logs. I hope this is acceptable.

https://review.coreboot.org/#/c/18993/3//COMMIT_MSG
Commit Message:

PS3, Line 9: Start-point was Gigabyte GA-G41M-ES2L.
> Could you make this two commits please, where the first one just copies tha
I think that would make review process more complicated since some things are generated mostly from scratch (gpio, devicetree, irq)...

sidenote: found some patches from Vladimir that push a lot of i945 stuff in northbridge code like sandy bridge which reduces code in mainboard a lot. Doing so should make adding i945 and x4x (which is has very similar functions) to autoport quite easy.


-- 
To view, visit https://review.coreboot.org/18993
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I992ee07b742dfc59733ce0f3a9be202a530ec6cc
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes