[coreboot-gerrit] Change in coreboot[master]: mainboard: Add Sapphire Pure Platinum H61

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18564 )

Change subject: mainboard: Add Sapphire Pure Platinum H61
......................................................................


Patch Set 13: Code-Review+2

(2 comments)

Nice that you hooked up libgfxinit!

https://review.coreboot.org/#/c/18564/13//COMMIT_MSG
Commit Message:

PS13, Line 33:  * Microsoft Windows 7 installer with libgfxinit
No need to change commit msg but I think there are some patches on Seabios ḾL that improve SeaVGABIOS to such extend that Windows bootloader works...


PS13, Line 47: * If an external card is inserted and the option
             :     ONBOARD_VGA_IS_PRIMARY is not enabled, the internal GPU
             :     disappears completely from the PCI bus.
This is the result of the combination of disable_peg() in nb/sandybridge/northbridge.c and gma_func0_disable() in nb/sandybridge/gma.c

I think simply removing 'dev->enabled = 0;' from gna_func0_disable might get you the results you want...

There was some talk on IRC about having more fine control over this behaviour (using nvram parameters), since it seems to be a bit different for many northbridges...

No need to change commit msg here.


-- 
To view, visit https://review.coreboot.org/18564
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76aca2cfc4708c1728ae03ee4f6bc59d976c28a0
Gerrit-PatchSet: 13
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Nicola Corna <nicola at corna.info>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nicola Corna <nicola at corna.info>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes