[coreboot-gerrit] Change in coreboot[master]: vboot: Assume EC_SOFTWARE_SYNC and VIRTUAL_DEV_SWITCH by def...

[Julius Werner (Code Review)]

Hello Aaron Durbin, build bot (Jenkins), Patrick Georgi, Furquan Shaikh,

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/18980

to look at the new patch set (#2).

Change subject: vboot: Assume EC_SOFTWARE_SYNC and VIRTUAL_DEV_SWITCH by default
......................................................................

vboot: Assume EC_SOFTWARE_SYNC and VIRTUAL_DEV_SWITCH by default

The virtualized developer switch was invented five years ago and has
been used on every vboot system ever since. We shouldn't need to specify
it again and again for every new board. This patch flips the Kconfig
logic around and replaces CONFIG_VIRTUAL_DEV_SWITCH with
CONFIG_PHYSICAL_DEV_SWITCH, so that only a few ancient boards need to
set it and it fits better with CONFIG_PHYSICAL_REC_SWITCH. (Also set the
latter for Lumpy which seems to have been omitted incorrectly, and hide
it from menuconfig since it's a hardware parameter that shouldn't be
configurable.)

Since almost all our developer switches are virtual, it doesn't make
sense for every board to pass a non-existent or non-functional developer
mode switch in the coreboot tables, so let's get rid of that. It's also
dangerously confusing for many boards to define a get_developer_mode()
function that reads an actual pin (often from a debug header) which will
not be honored by coreboot because CONFIG_PHYSICAL_DEV_SWITCH isn't set.
Therefore, this patch removes all those non-functional instances of that
function. In the future, either the board has a physical dev switch and
must define it, or it doesn't and must not.

In a similar sense (and since I'm touching so many board configs
anyway), it's annoying that we have to keep selecting EC_SOFTWARE_SYNC.
Instead, it should just be assumed by default whenever a Chrome EC is
present in the system. This way, it can also still be overridden by
menuconfig.

CQ-DEPEND=CL:459701

Change-Id: If9cbaa7df530580a97f00ef238e3d9a8a86a4a7f
Signed-off-by: Julius Werner <jwerner at chromium.org>
---
M src/mainboard/google/auron/Kconfig
M src/mainboard/google/auron/chromeos.c
M src/mainboard/google/beltino/Kconfig
M src/mainboard/google/beltino/chromeos.c
M src/mainboard/google/butterfly/chromeos.c
M src/mainboard/google/chell/chromeos.c
M src/mainboard/google/cosmos/chromeos.c
M src/mainboard/google/cyan/Kconfig
M src/mainboard/google/cyan/chromeos.c
M src/mainboard/google/daisy/chromeos.c
M src/mainboard/google/eve/chromeos.c
M src/mainboard/google/fizz/chromeos.c
M src/mainboard/google/foster/Kconfig
M src/mainboard/google/foster/chromeos.c
M src/mainboard/google/gale/Kconfig
M src/mainboard/google/gale/chromeos.c
M src/mainboard/google/glados/chromeos.c
M src/mainboard/google/gru/Kconfig
M src/mainboard/google/jecht/Kconfig
M src/mainboard/google/jecht/chromeos.c
M src/mainboard/google/lars/chromeos.c
M src/mainboard/google/link/chromeos.c
M src/mainboard/google/nyan/Kconfig
M src/mainboard/google/nyan/chromeos.c
M src/mainboard/google/nyan_big/Kconfig
M src/mainboard/google/nyan_big/chromeos.c
M src/mainboard/google/nyan_blaze/Kconfig
M src/mainboard/google/nyan_blaze/chromeos.c
M src/mainboard/google/oak/Kconfig
M src/mainboard/google/oak/chromeos.c
M src/mainboard/google/parrot/chromeos.c
M src/mainboard/google/peach_pit/chromeos.c
M src/mainboard/google/poppy/chromeos.c
M src/mainboard/google/purin/chromeos.c
M src/mainboard/google/rambi/Kconfig
M src/mainboard/google/rambi/chromeos.c
M src/mainboard/google/reef/chromeos.c
M src/mainboard/google/rotor/chromeos.c
M src/mainboard/google/slippy/Kconfig
M src/mainboard/google/slippy/chromeos.c
M src/mainboard/google/smaug/Kconfig
M src/mainboard/google/smaug/chromeos.c
M src/mainboard/google/storm/Kconfig
M src/mainboard/google/storm/chromeos.c
M src/mainboard/google/stout/chromeos.c
M src/mainboard/google/urara/chromeos.c
M src/mainboard/google/veyron/Kconfig
M src/mainboard/google/veyron/chromeos.c
M src/mainboard/google/veyron_mickey/Kconfig
M src/mainboard/google/veyron_mickey/chromeos.c
M src/mainboard/google/veyron_rialto/Kconfig
M src/mainboard/google/veyron_rialto/chromeos.c
M src/mainboard/intel/baskingridge/chromeos.c
M src/mainboard/intel/emeraldlake2/chromeos.c
M src/mainboard/intel/galileo/vboot.c
M src/mainboard/intel/kblrvp/chromeos.c
M src/mainboard/intel/kunimitsu/chromeos.c
M src/mainboard/intel/strago/Kconfig
M src/mainboard/intel/strago/chromeos.c
M src/mainboard/intel/wtm2/chromeos.c
M src/mainboard/samsung/lumpy/Kconfig
M src/mainboard/samsung/stumpy/Kconfig
M src/soc/intel/apollolake/Kconfig
M src/soc/intel/skylake/Kconfig
M src/vboot/bootmode.c
M src/vboot/vboot_handoff.c
M src/vboot/vboot_logic.c
M src/vendorcode/google/chromeos/Kconfig
M src/vendorcode/google/chromeos/chromeos.c
69 files changed, 17 insertions(+), 288 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/18980/2
-- 
To view, visit https://review.coreboot.org/18980
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If9cbaa7df530580a97f00ef238e3d9a8a86a4a7f
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins)