[coreboot-gerrit] Change in coreboot[master]: chromeos / broadwell: Make save_chromeos_gpios() broadwell-s...

[Julius Werner (Code Review)]

Hello Aaron Durbin, Patrick Georgi, Furquan Shaikh,

I'd like you to do a code review.  Please visit

    https://review.coreboot.org/18981

to review the following change.


Change subject: chromeos / broadwell: Make save_chromeos_gpios() broadwell-specific
......................................................................

chromeos / broadwell: Make save_chromeos_gpios() broadwell-specific

This callback was only required for a single SoC, and is only called in
that SoC's code. It makes more sense to define the weak noop stub in the
same SoC file rather than in a generic chromeos file. (This makes it
easier to separate vboot and chromeos code in a later patch.)

Change-Id: I9cf67a75a052d1c86eda0393b6a9fbbe255fedf8
Signed-off-by: Julius Werner <jwerner at chromium.org>
---
M src/soc/intel/broadwell/romstage/romstage.c
M src/vendorcode/google/chromeos/chromeos.c
2 files changed, 7 insertions(+), 5 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/18981/1

diff --git a/src/soc/intel/broadwell/romstage/romstage.c b/src/soc/intel/broadwell/romstage/romstage.c
index bd63e00..58ba732 100644
--- a/src/soc/intel/broadwell/romstage/romstage.c
+++ b/src/soc/intel/broadwell/romstage/romstage.c
@@ -37,6 +37,13 @@
 #include <soc/spi.h>
 #include <vendorcode/google/chromeos/chromeos.h>
 
+#if IS_ENABLED(CONFIG_CHROMEOS)
+void __attribute__((weak)) save_chromeos_gpios(void)
+{
+	// Can be implemented by a mainboard
+}
+#endif
+
 /* Entry from cache-as-ram.inc. */
 asmlinkage void *romstage_main(unsigned long bist,
 				uint32_t tsc_low, uint32_t tsc_hi)
diff --git a/src/vendorcode/google/chromeos/chromeos.c b/src/vendorcode/google/chromeos/chromeos.c
index 4edf74a..515b79f 100644
--- a/src/vendorcode/google/chromeos/chromeos.c
+++ b/src/vendorcode/google/chromeos/chromeos.c
@@ -23,11 +23,6 @@
 	return 0;
 }
 
-void __attribute__((weak)) save_chromeos_gpios(void)
-{
-	// Can be implemented by a mainboard
-}
-
 int __attribute__((weak)) get_sw_write_protect_state(void)
 {
 	// Can be implemented by a platform / mainboard

-- 
To view, visit https://review.coreboot.org/18981
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9cf67a75a052d1c86eda0393b6a9fbbe255fedf8
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>