[coreboot-gerrit] Change in coreboot[master]: arm64: Fix verstage to use proper assembly versions of mem*()

Julius Werner (Code Review) gerrit at coreboot.org
Sat Mar 25 02:58:35 CET 2017


Hello Aaron Durbin, Patrick Georgi, Furquan Shaikh,

I'd like you to do a code review.  Please visit

    https://review.coreboot.org/18976

to review the following change.


Change subject: arm64: Fix verstage to use proper assembly versions of mem*()
......................................................................

arm64: Fix verstage to use proper assembly versions of mem*()

Do to an unfortunate race between adding verstage support and reverting
an earlier hack that disabled the optimized assembly versions of
memcpy(), memmove() and memset() on ARM64, it seems that we never
enabled the optimized code for the verstage. This should be fixed so
that all stages use the same architecture support code.

Change-Id: I0bf3245e346105492030f4b133729c4d11bdb3ff
Signed-off-by: Julius Werner <jwerner at chromium.org>
---
M src/arch/arm64/Makefile.inc
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/18976/1

diff --git a/src/arch/arm64/Makefile.inc b/src/arch/arm64/Makefile.inc
index 95bc58d..7f3ce3f 100644
--- a/src/arch/arm64/Makefile.inc
+++ b/src/arch/arm64/Makefile.inc
@@ -72,9 +72,9 @@
 verstage-y += boot.c
 verstage-y += div0.c
 verstage-y += eabi_compat.c
-verstage-y += ../../lib/memset.c
-verstage-y += ../../lib/memcpy.c
-verstage-y += ../../lib/memmove.c
+verstage-y += memset.S
+verstage-y += memcpy.S
+verstage-y += memmove.S
 
 verstage-y += transition.c transition_asm.S
 

-- 
To view, visit https://review.coreboot.org/18976
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bf3245e346105492030f4b133729c4d11bdb3ff
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>



More information about the coreboot-gerrit mailing list