[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy: Add ASL entries for IMGU and CIO2 devices

[V Sowmya (Code Review)]

Hello Rizwan Qureshi,

I'd like you to do a code review.  Please visit

    https://review.coreboot.org/18968

to review the following change.


Change subject: mb/google/poppy: Add ASL entries for IMGU and CIO2 devices
......................................................................

mb/google/poppy: Add ASL entries for IMGU and CIO2 devices

Add ASL entries for IMGU and CIO2 devices

* _CCA ACPI object to report that there is no Cache Coherent DMA support.
* CAMD ACPI object to specify the device type.
These ACPI objects are used by Intel kernel drivers.

BUG=b:36580624
BRANCH=none
TEST=Build and boot poppy. Dump and verify that DSDT table
has the entries for IMGU and CIO2 devices.

Change-Id: I13050253e18408cdb1e196f8003b3f43299aa5a5
Signed-off-by: Sowmya V <v.sowmya at intel.com>
Signed-off-by: Rizwan Qureshi <rizwan.qureshi at intel.com>
---
A src/mainboard/google/poppy/acpi/ipu.asl
M src/mainboard/google/poppy/dsdt.asl
2 files changed, 34 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/18968/2

diff --git a/src/mainboard/google/poppy/acpi/ipu.asl b/src/mainboard/google/poppy/acpi/ipu.asl
new file mode 100644
index 0000000..f1099ed
--- /dev/null
+++ b/src/mainboard/google/poppy/acpi/ipu.asl
@@ -0,0 +1,32 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2017 Intel Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+/* IPU3 input system - Device 05, Function 0 */
+Device (IMGU)
+{
+	Name (_ADR, 0x00050000)
+	Name (_DDN, "Imaging Unit")
+	Name (_CCA, ZERO)
+	Name (CAMD, 0x01)
+}
+
+/* IPU3 processing system */
+Device (CIO2)
+{
+	Name (_ADR, 0x00140003)
+	Name (_DDN, "Camera and Imaging Subsystem")
+	Name (_CCA, ZERO)
+	Name (CAMD, 0x00)
+}
diff --git a/src/mainboard/google/poppy/dsdt.asl b/src/mainboard/google/poppy/dsdt.asl
index 2007691..087f9dc 100644
--- a/src/mainboard/google/poppy/dsdt.asl
+++ b/src/mainboard/google/poppy/dsdt.asl
@@ -42,6 +42,8 @@
 		}
 		Device (PCI0)
 		{
+			/* Image processing unit */
+			#include "acpi/ipu.asl"
 			#include <soc/intel/skylake/acpi/systemagent.asl>
 			#include <soc/intel/skylake/acpi/pch.asl>
 		}

-- 
To view, visit https://review.coreboot.org/18968
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I13050253e18408cdb1e196f8003b3f43299aa5a5
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>