[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Code clean up to use soc/intel/common/...

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/18555 )

Change subject: soc/intel/apollolake: Code clean up to use soc/intel/common/block/cpu/car
......................................................................


Patch Set 20:

(2 comments)

https://review.coreboot.org/#/c/18555/20/src/soc/intel/apollolake/Kconfig
File src/soc/intel/apollolake/Kconfig:

PS20, Line 127: config SOC_INTEL_COMMON_BLOCK_CAR
              : 	bool
              : 	default y if !FSP_CAR
              : 	select INTEL_CAR_CQOS
> mistake, will remove this code.
Done


Line 285: 	  CAR and use remainder for actual caching.
> you can just add this:
Done


-- 
To view, visit https://review.coreboot.org/18555
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67f909f50a24f009b3e35388665251be1dde40f7
Gerrit-PatchSet: 20
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes