[coreboot-gerrit] Change in coreboot[master]: cr50: check if the new image needs to be enabled and act on it

[Vadim Bendebury (Code Review)]

Vadim Bendebury has posted comments on this change. ( https://review.coreboot.org/18946 )

Change subject: cr50: check if the new image needs to be enabled and act on it
......................................................................


Patch Set 3:

(3 comments)

https://review.coreboot.org/#/c/18946/3/src/vendorcode/google/chromeos/cr50_enable_update.c
File src/vendorcode/google/chromeos/cr50_enable_update.c:

PS3, Line 37: reset_pending
> While it is true if this variable is non-zero a reset will be pending shoul
ah, yes, I missed this. But this patch is also mostly an RFC for the shutdown sequence.


PS3, Line 48: CR50
> Should we name this CR50 knowing there will be other versions in the future
ok, I'll rename this


Line 50: 	halt();
> It doesn't shut down the platform. poweroff() is supposed to power off the 
Will 'poweroff' shut down the EC as well?

And yes, I was going to try this on Bob.


-- 
To view, visit https://review.coreboot.org/18946
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45fd6058c03f32ff8edccd56ca2aa5359d9b21b1
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes