[coreboot-gerrit] Change in coreboot[master]: cr50: check if the new image needs to be enabled and act on it

[Vadim Bendebury (Code Review)]

Vadim Bendebury has posted comments on this change. ( https://review.coreboot.org/18946 )

Change subject: cr50: check if the new image needs to be enabled and act on it
......................................................................


Patch Set 3:

(4 comments)

https://review.coreboot.org/#/c/18946/3/src/vendorcode/google/chromeos/cr50_enable_update.c
File src/vendorcode/google/chromeos/cr50_enable_update.c:

Line 50: 	halt();
is this graceful enough or something else is required?


https://review.coreboot.org/#/c/18946/1/src/vendorcode/google/chromeos/cr50_turn_on.c
File src/vendorcode/google/chromeos/cr50_turn_on.c:

Line 2
> The name of this file is pretty poor. cr50_turn_on? More like cr50_enable_u
name changed


PS1, Line 44: 
            : 
> Yes, we need to add a new event type to elog. Add the event here. mosys nee
added a new event.


PS1, Line 44: 
            : 
> On the cr50 side we should prevent a deep sleep when a reset is requested i
good point, I'll look into it. Don't remember if deferred hook prevents deep sleeping or not.


-- 
To view, visit https://review.coreboot.org/18946
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45fd6058c03f32ff8edccd56ca2aa5359d9b21b1
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes