[coreboot-gerrit] Change in coreboot[master]: google/chromeec: Ensure \_SB.LID0 is present before using it

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/18941 )

Change subject: google/chromeec: Ensure \_SB.LID0 is present before using it
......................................................................


Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/18941/5/src/ec/google/chromeec/acpi/ec.asl
File src/ec/google/chromeec/acpi/ec.asl:

Line 30: External (\_SB.LID0, DeviceObj)
> This breaks with older iasl (eg the one used in CrOS) on link, because the 
Okay. I will take a look. I think the right thing to do here would be to remove \_SB.LID0 from all boards and make them use EC_ENABLE_LID_SWITCH. I will take a look if that is possible.


-- 
To view, visit https://review.coreboot.org/18941
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92433460ec870fb07f48e67a6dfc61e3c036a129
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes