[coreboot-gerrit] Change in coreboot[master]: superio/fintek: Add support for Fintek F71808A

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/18563 )

Change subject: superio/fintek: Add support for Fintek F71808A
......................................................................


Patch Set 7: Code-Review-1

(2 comments)

please fix the numbering of the multi function registers so that they aren't different to the datasheet

https://review.coreboot.org/#/c/18563/7/src/superio/fintek/f71808a/chip.h
File src/superio/fintek/f71808a/chip.h:

PS7, Line 26: 	uint8_t multi_function_register_1;
            : 	uint8_t multi_function_register_2;
            : 	uint8_t multi_function_register_3;
            : 	uint8_t multi_function_register_4;
            : 	uint8_t multi_function_register_5;
in the datasheet those registers begin with 0 and here they begin with 1. this can easily cause off-by-one errors...
you also need to patch the devicetree.cb of the board using it accordingly.


https://review.coreboot.org/#/c/18563/7/src/superio/fintek/f71808a/f71808a_multifunc.c
File src/superio/fintek/f71808a/f71808a_multifunc.c:

PS7, Line 24: #define MULTI_FUNC_SEL_REG1 0x28
            : #define MULTI_FUNC_SEL_REG2 0x29
            : #define MULTI_FUNC_SEL_REG3 0x2A
            : #define MULTI_FUNC_SEL_REG4 0x2B
            : #define MULTI_FUNC_SEL_REG5 0x2C
in the datasheet those registers begin with 0 and here they begin with 1. this can easily cause off-by-one errors...


-- 
To view, visit https://review.coreboot.org/18563
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba3f3dadf2b15071981f52d0b08da7847354bd23
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Nicola Corna <nicola at corna.info>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nicola Corna <nicola at corna.info>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes