[coreboot-gerrit] Change in coreboot[master]: mainboard/google/reef: Configure sdcard card detect (CD) pin...

Venkateswarlu V Vinjamuri (Code Review) gerrit at coreboot.org
Thu Mar 23 20:00:20 CET 2017


Venkateswarlu V Vinjamuri has posted comments on this change. ( https://review.coreboot.org/18948 )

Change subject: mainboard/google/reef: Configure sdcard card detect (CD) pin GPIO_177
......................................................................


Patch Set 3:

(3 comments)

https://review.coreboot.org/#/c/18948/3//COMMIT_MSG
Commit Message:

PS3, Line 7: cd
> What does *cd* mean?
Done


PS3, Line 9: functio
> function
Done


Line 10: This enables OS to boot from sdcard.
> Please add a blank line between paragraphs.
Done


-- 
To view, visit https://review.coreboot.org/18948
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73901d4a1b39752cbc452f3286d494587dac95d4
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Venkateswarlu V Vinjamuri <venkateswarlu.v.vinjamuri at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Vaibhav Shankar <vaibhav.shankar at intel.com>
Gerrit-Reviewer: Venkateswarlu V Vinjamuri <venkateswarlu.v.vinjamuri at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list