[coreboot-gerrit] Change in coreboot[master]: crossgcc/Dockerfile: Add gnat to build the Ada toolchain

Martin Roth (Code Review) gerrit at coreboot.org
Thu Mar 23 18:55:24 CET 2017


Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/18772 )

Change subject: crossgcc/Dockerfile: Add gnat to build the Ada toolchain
......................................................................


crossgcc/Dockerfile: Add gnat to build the Ada toolchain

If gnat is installed, buildgcc automatically enables Ada support.
Instead of the general `gnat` package we install `gnat-6` which saves
us about 80 MiB of downloads of unused "dependencies".

Change-Id: Ie0b8564d016d458cd33ff75a2ee7bbd5de33afe2
Signed-off-by: Nico Huber <nico.h at gmx.de>
Reviewed-on: https://review.coreboot.org/18772
Tested-by: build bot (Jenkins)
Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
Reviewed-by: Martin Roth <martinroth at google.com>
---
M util/crossgcc/Dockerfile
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Philippe Mathieu-Daudé: Looks good to me, but someone else must approve
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved
  Martin Roth: Looks good to me, approved



diff --git a/util/crossgcc/Dockerfile b/util/crossgcc/Dockerfile
index da3c840..9f1a58c 100644
--- a/util/crossgcc/Dockerfile
+++ b/util/crossgcc/Dockerfile
@@ -5,8 +5,8 @@
 	useradd -p locked -m coreboot && \
 	apt-get -qq update && \
 	apt-get -qq upgrade && \
-	apt-get -qqy install gcc g++ make patch python diffutils bison flex \
-		git doxygen ccache subversion p7zip-full unrar-free \
+	apt-get -qqy install gcc g++ gnat-6 make patch python diffutils bison \
+		flex git doxygen ccache subversion p7zip-full unrar-free \
 		m4 wget curl bzip2 vim-common cmake xz-utils pkg-config \
 		dh-autoreconf unifont \
 		libssl-dev libgmp-dev zlib1g-dev libpci-dev liblzma-dev \
@@ -22,7 +22,8 @@
 
 RUN \
 	cd /root/coreboot/util/crossgcc && \
-	make all_without_gdb CPUS=$(nproc) DEST=/opt/xgcc && \
+	make all_without_gdb \
+        	BUILD_LANGUAGES=c,ada CPUS=$(nproc) DEST=/opt/xgcc && \
 	cd /root && \
 	rm -rf coreboot
 

-- 
To view, visit https://review.coreboot.org/18772
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0b8564d016d458cd33ff75a2ee7bbd5de33afe2
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list