[coreboot-gerrit] Change in coreboot[master]: mainboard/technexion/tim5690: transition away from device_t

Patrick Georgi (Code Review) gerrit at coreboot.org
Thu Mar 23 18:51:44 CET 2017


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/17307 )

Change subject: mainboard/technexion/tim5690: transition away from device_t
......................................................................


mainboard/technexion/tim5690: transition away from device_t

Replace the use of the old device_t definition inside
mainboard/technexion/tim5690.

Change-Id: I661daa5ab34c70db8ed783e5bf1114877f13b548
Signed-off-by: Antonello Dettori <dev at dettori.io>
Reviewed-on: https://review.coreboot.org/17307
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
---
M src/mainboard/technexion/tim5690/tn_post_code.c
1 file changed, 5 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved



diff --git a/src/mainboard/technexion/tim5690/tn_post_code.c b/src/mainboard/technexion/tim5690/tn_post_code.c
index fba0d75..ad2e9d4 100644
--- a/src/mainboard/technexion/tim5690/tn_post_code.c
+++ b/src/mainboard/technexion/tim5690/tn_post_code.c
@@ -30,13 +30,13 @@
 #include "tn_post_code.h"
 
 
-#ifdef __PRE_RAM__
+#ifdef __SIMPLE_DEVICE__
 
 // TechNexion's Post Code Initially.
 void technexion_post_code_init(void)
 {
 	uint8_t reg8_data;
-	device_t dev = 0;
+	pci_devfn_t dev = 0;
 
 	// SMBus Module and ACPI Block (Device 20, Function 0)
 	dev = pci_locate_device(PCI_ID(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SB600_SM), 0);
@@ -129,12 +129,13 @@
 void technexion_post_code(uint8_t udata8)
 {
 	uint8_t u8_data;
-	device_t dev = 0;
 
 	// SMBus Module and ACPI Block (Device 20, Function 0)
-#ifdef __PRE_RAM__
+#ifdef __SIMPLE_DEVICE__
+	pci_devfn_t dev = 0;
 	dev = pci_locate_device(PCI_ID(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SB600_SM), 0);
 #else
+	device_t dev = 0;
 	dev = dev_find_device(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SB600_SM, 0);
 #endif
 

-- 
To view, visit https://review.coreboot.org/17307
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I661daa5ab34c70db8ed783e5bf1114877f13b548
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Antonello Dettori <dev at dettori.io>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list