[coreboot-gerrit] Change in coreboot[master]: nb/x4x/nortbridge.c: Fix resource allocation when IGD is dis...

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18511 )

Change subject: nb/x4x/nortbridge.c: Fix resource allocation when IGD is disabled
......................................................................


Patch Set 5: Code-Review-2

(1 comment)

https://review.coreboot.org/#/c/18511/5/src/northbridge/intel/x4x/northbridge.c
File src/northbridge/intel/x4x/northbridge.c:

PS5, Line 67: if (!(ggc & 2)) {
I'm not sure if UMA can be reclaimed like is attempted here if GSM and GMS are non-zero. I suspect this might have been the issue I was having, where I tried to solve it by disabling IGD before raminit.


-- 
To view, visit https://review.coreboot.org/18511
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e6898c06a2bc1016eeaa3f002ff6c39657018ae
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes