[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: [WIP]Add Intel common FAST_SPI code

[Barnali Sarkar (Code Review)]

Barnali Sarkar has posted comments on this change. ( https://review.coreboot.org/18557 )

Change subject: soc/intel/common/block: [WIP]Add Intel common FAST_SPI code
......................................................................


Patch Set 12:

(5 comments)

https://review.coreboot.org/#/c/18557/12/src/soc/intel/common/block/fast_spi/fast_spi.c
File src/soc/intel/common/block/fast_spi/fast_spi.c:

Line 21: void *get_spi_bar(void)
> All these functions in here should be namespaced accoringly. 
ok, will do it.


Line 38: size_t get_bios_rom_region_size()
> There are users of this would actually need the start as well. This functio
will fix this.


PS12, Line 48: 4 * 1024
> Include commonlib/helpers.h. 4 * KiB
ok


Line 50: 		     SPIBAR_BFPREG_PRL_SHIFT) + 1) * 4 * 1024;
> Just do the math then multiply by 4 * KiB.
ok


https://review.coreboot.org/#/c/18557/12/src/soc/intel/common/block/include/intelblocks/fast_spi.h
File src/soc/intel/common/block/include/intelblocks/fast_spi.h:

Line 87: #define SPIBAR_HSFSTS_W1C_BITS		(0xff)
> All these macros in here are for doing the SPI transactions. Why are they e
Yes, these MACROs are doing SPI MMIO transactions. 
Although, they are not used in Bootblock Phase, but I have added them here, since I thought of making the complete common header for Fast SPI Controller at a single place.
I will push next, Clean-up patches of SKL and APL, which will clean the old header usage stuffs, and use this new common header for SKL and APL.


-- 
To view, visit https://review.coreboot.org/18557
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I046e3b30c8efb172851dd17f49565c9ec4cb38cb
Gerrit-PatchSet: 12
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Pratikkumar Prajapati <pratikkumar.v.prajapati at intel.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes