[coreboot-gerrit] Change in coreboot[master]: soc/pci_devs.h: Use consistent naming in soc/pci_devs.h

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/18576 )

Change subject: soc/pci_devs.h: Use consistent naming in soc/pci_devs.h
......................................................................


Patch Set 16:

(2 comments)

https://review.coreboot.org/#/c/18576/16/src/soc/intel/apollolake/include/soc/i2c.h
File src/soc/intel/apollolake/include/soc/i2c.h:

PS16, Line 34: SIO1
> SIO2
my bad, sorry


https://review.coreboot.org/#/c/18576/16/src/soc/intel/common/block/cse/cse.c
File src/soc/intel/common/block/cse/cse.c:

Line 83: 	device_t dev = PCH_DEV_ME;
> What is intel going to call this thing? Is it an ME? CSE? TXE? HECI1? Do we
i guess it should be CSE because now we have CSE common module as well. will modify name and use the same in both small and big core


-- 
To view, visit https://review.coreboot.org/18576
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e4c7502e9678c0a367e9c7a96cf848d5b24f68e
Gerrit-PatchSet: 16
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Pratikkumar Prajapati <pratikkumar.v.prajapati at intel.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-HasComments: Yes