[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Add Intel common systemagent support...

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/18454 )

Change subject: soc/intel/common/block: Add Intel common systemagent support[WIP]
......................................................................


Patch Set 12:

(3 comments)

https://review.coreboot.org/#/c/18454/12/src/soc/intel/common/block/systemagent/Kconfig
File src/soc/intel/common/block/systemagent/Kconfig:

PS12, Line 6: PCIEX_BASE_ADDRESS
> This is a new Kconfig. Why is this value disjoint with the one used in the 
Done


Line 14: 	default 0x04 if (PCIEX_LENGTH_64MB)
> These values are weird in that you are pre-encoding the field shifted by 1 
Done


PS12, Line 15: 	default 0x03
> Why not add another default of 0x0? Then it's 256MiB out of the gate and no
Done


-- 
To view, visit https://review.coreboot.org/18454
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8a77aec8b20bafd4175048d442701250f1aa9c8
Gerrit-PatchSet: 12
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-HasComments: Yes