[coreboot-gerrit] Change in coreboot[master]: [WIP] mainboards/hp: Add HP Elitebook 2760p

Iru Cai (Code Review) gerrit at coreboot.org
Thu Mar 23 09:00:02 CET 2017


Iru Cai has posted comments on this change. ( https://review.coreboot.org/18241 )

Change subject: [WIP] mainboards/hp: Add HP Elitebook 2760p
......................................................................


Patch Set 13: Code-Review-1

(1 comment)

https://review.coreboot.org/#/c/18241/13/src/mainboard/hp/2760p/mainboard.c
File src/mainboard/hp/2760p/mainboard.c:

PS13, Line 49: 	
The code seems not so good, but the fan control works now.
I think I need to put the code to ec/hp/kbc1126.


-- 
To view, visit https://review.coreboot.org/18241
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ffdb9f9c71f6c9a84e896abc3c424c8dd4bed0e
Gerrit-PatchSet: 13
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Iru Cai <mytbk920423 at gmail.com>
Gerrit-Reviewer: Iru Cai <mytbk920423 at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Swift Geek <swiftgeek at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list