[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Remove unused CAR_GLOBAL variable
Subrata Banik (Code Review)
gerrit at coreboot.org
Thu Mar 23 07:26:23 CET 2017
Subrata Banik has uploaded a new change for review. ( https://review.coreboot.org/18949 )
Change subject: soc/intel/apollolake: Remove unused CAR_GLOBAL variable
......................................................................
soc/intel/apollolake: Remove unused CAR_GLOBAL variable
Also move all local variable declaration at starting of function
block.
Change-Id: I774485a23b4b7d96a8dbd837da45553251dff3b0
Signed-off-by: Subrata Banik <subrata.banik at intel.com>
---
M src/soc/intel/apollolake/mmap_boot.c
1 file changed, 2 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/18949/1
diff --git a/src/soc/intel/apollolake/mmap_boot.c b/src/soc/intel/apollolake/mmap_boot.c
index a92fbb3..50d0ff0 100644
--- a/src/soc/intel/apollolake/mmap_boot.c
+++ b/src/soc/intel/apollolake/mmap_boot.c
@@ -58,7 +58,6 @@
*
*/
-static size_t bios_start CAR_GLOBAL;
static size_t bios_size CAR_GLOBAL;
static struct mem_region_device shadow_dev CAR_GLOBAL;
@@ -66,16 +65,14 @@
static void bios_mmap_init(void)
{
- size_t size;
+ size_t size, start, bios_end, bios_mapped_size;
+ uintptr_t base;
size = car_get_var(bios_size);
/* If bios_size is initialized, then bail out. */
if (size != 0)
return;
-
- size_t start, bios_end, bios_mapped_size;
- uintptr_t base;
/*
* BIOS_BFPREG provides info about BIOS Flash Primary Region
@@ -110,7 +107,6 @@
start, bios_mapped_size,
CONFIG_ROM_SIZE);
- car_set_var(bios_start, start);
car_set_var(bios_size, size);
}
--
To view, visit https://review.coreboot.org/18949
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I774485a23b4b7d96a8dbd837da45553251dff3b0
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
More information about the coreboot-gerrit
mailing list