[coreboot-gerrit] Change in coreboot[master]: google/fizz: Update device tree

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/18944 )

Change subject: google/fizz: Update device tree
......................................................................


Patch Set 1:

(12 comments)

https://review.coreboot.org/#/c/18944/1/src/mainboard/google/fizz/devicetree.cb
File src/mainboard/google/fizz/devicetree.cb:

PS1, Line 37: ScsEmmcEnabled
0?


PS1, Line 38: 1
0?


PS1, Line 140: Bluetooth
Comment doesn't apply


PS1, Line 141: "USB2_PORT_LONG(OC1)"	# Type-C Port 2
This is not right.
usb2_ports[3] = "USB2_PORT_MID(OC_SKIP)"
usb2_ports[4] = "USB2_PORT_MID(OC_SKIP)"
usb2_ports[5] = "USB2_PORT_MID(OC_SKIP)"


PS1, Line 142: Type-A Port
Bluetooth


PS1, Line 143: 8
7


PS1, Line 146: USB3_PORT_DEFAULT(OC1)"	# Type-C Port 2
USB3_PORT_DEFAULT(OC_SKIP)


PS1, Line 148: USB3_PORT_EMPTY
USB3_PORT_DEFAULT(OC_SKIP)


PS1, Line 150: Touchscreen
comment doesn't apply


PS1, Line 151: NFC
comment doesn't apply


PS1, Line 152: Camera
comment doesn't apply


PS1, Line 223: on
off


-- 
To view, visit https://review.coreboot.org/18944
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92cf9baa4c3aefc6983511543d875e74a6b0bf94
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes