[coreboot-gerrit] Change in coreboot[master]: mainboard/neoware/g170: Copy from mainboard/bcom/winnetp680

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/18898 )

Change subject: mainboard/neoware/g170: Copy from mainboard/bcom/winnetp680
......................................................................


Patch Set 1: Code-Review+1

(3 comments)

https://review.coreboot.org/#/c/18898/1//COMMIT_MSG
Commit Message:

PS1, Line 9: in HP
Please wrap to the next line.


https://review.coreboot.org/#/c/18898/1/src/mainboard/neoware/g170/romstage.c
File src/mainboard/neoware/g170/romstage.c:

Line 30: #include "southbridge/via/vt8237r/early_smbus.c"
> We are slowly removing all .c includes.
See this commit:
https://review.coreboot.org/#/c/18484/


Line 41: #include "northbridge/via/cn700/raminit.c"
> Dito. It would be nice if you fixed all the VIA CN700 boards. Preferably be
While that would be nice, I don't think it's fair to expect people to go back and fix other platforms as a condition to submit a new platform.  If we can fix just this platform in a follow-on, that's enough for me.


-- 
To view, visit https://review.coreboot.org/18898
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90b89ee634d90cfba2e56cca5b76cfd2bd7a8d0b
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lubomir Rintel <lkundrak at v3.sk>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes