[coreboot-gerrit] Change in coreboot[master]: intelvbttool: Add several fixes

Martin Roth (Code Review) gerrit at coreboot.org
Wed Mar 22 18:07:30 CET 2017


Martin Roth has posted comments on this change. ( https://review.coreboot.org/18902 )

Change subject: intelvbttool: Add several fixes
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/18902/1/util/intelvbttool/intelvbttool.c
File util/intelvbttool/intelvbttool.c:

Line 530: 
Add check to verify that vbt_offset is inside the rom?


PS1, Line 561: [<output file>]
Any reason outputfile is separate from the dump param?

wouldn't -d [outputfile] make more sense?


-- 
To view, visit https://review.coreboot.org/18902
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8cbde042c7f5632f36648419becd23e248ba6f76
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list