[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: [WIP]Add Intel common SPI code

[Barnali Sarkar (Code Review)]

Barnali Sarkar has posted comments on this change. ( https://review.coreboot.org/18557 )

Change subject: soc/intel/common/block: [WIP]Add Intel common SPI code
......................................................................


Patch Set 7:

> My original comment still stands as intel's highly-specific spi
 > flash controller implementation for a boot medium is not anywhere
 > related to a generic spi controller:
 > 
 > I think you probably want to call this module 'fast spi' because
 > that's what intel refers to its hardware spi controller for the
 > boot media.

Yes, I understood your point. Thats why, I made the Block Module name as "fast_spi".
Do you want me to change the spi.c file name to "fast_spi.c" and also the header file inside intelblocks as "fast_spi.h" ?

Also I wanted to tell that I am in process to make a separate patch for making a SPI header common for Big Core and Small Core inside intelblocks where I will keep all SPI PCI Configuration Space Register offsets and Memory Mapped Space Register offsets that are all common. Then I will use the same header file for existing SKL and APL code. Next, I will add this Common FAST_SPI block module patch, and then use the same common module for APL and SKL platforms.

-- 
To view, visit https://review.coreboot.org/18557
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I046e3b30c8efb172851dd17f49565c9ec4cb38cb
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Pratikkumar Prajapati <pratikkumar.v.prajapati at intel.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No