[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Create API to read SPI Flash MMIO register

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/18921 )

Change subject: soc/intel/skylake: Create API to read SPI Flash MMIO register
......................................................................


Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/18921/3//COMMIT_MSG
Commit Message:

PS3, Line 7: SPI Flash
> Can we find a better name for this? I thought about `SPI controller`.
Done


https://review.coreboot.org/#/c/18921/3/src/soc/intel/skylake/flash_controller.c
File src/soc/intel/skylake/flash_controller.c:

Line 131: static uint32_t _spi_flash_ctrlr_reg_read(uint8_t *spi_bar, uint16_t reg)
> If this isn't being used for anything else why introduce it? Why not just
Done


-- 
To view, visit https://review.coreboot.org/18921
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43400aa7204c27c73fd70e93027005d19def56ac
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Pratikkumar Prajapati <pratikkumar.v.prajapati at intel.corp-partner.google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-HasComments: Yes