[coreboot-gerrit] Change in coreboot[master]: cpu/x86/mp_init.c: Remove hard coded timeout in bsp_do_fligh...

Anonymous Coward (Code Review) gerrit at coreboot.org
Wed Mar 22 11:05:47 CET 2017


Hello Kyösti Mälkki, Aaron Durbin, Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/18931

to look at the new patch set (#3).

Change subject: cpu/x86/mp_init.c: Remove hard coded timeout in bsp_do_flight_plan
......................................................................

cpu/x86/mp_init.c: Remove hard coded timeout in bsp_do_flight_plan

This fix removes hard coded and const. timeout in bsp_do_flight_plan.
A new weak get_bsp_timeout_us function is defined instead,
which can be overridden if needed.

The old value = 100ms can be not enough in case of more than 8 cores
is used during debug session with high log level.

Change-Id: Ic0787009e8286b13bc76f763758e42aa6d6782d4
Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak at intel.com>
---
M src/cpu/x86/mp_init.c
M src/include/cpu/x86/mp.h
2 files changed, 15 insertions(+), 2 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/18931/3
-- 
To view, visit https://review.coreboot.org/18931
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic0787009e8286b13bc76f763758e42aa6d6782d4
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: tomaszx.jozwiak at intel.com
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: tomaszx.jozwiak at intel.com



More information about the coreboot-gerrit mailing list