[coreboot-gerrit] Change in coreboot[master]: Move common EFI and FSP definitions to commonlib

Adurb Akhbar (Code Review) gerrit at coreboot.org
Wed Mar 22 06:49:28 CET 2017


Hello Kyösti Mälkki, Aaron Durbin, Stefan Reinauer, Paul Menzel, build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/18929

to look at the new patch set (#3).

Change subject: Move common EFI and FSP definitions to commonlib
......................................................................

Move common EFI and FSP definitions to commonlib

The original implementation of fsp_component_relocate() was very lazy
in that it indiscriminately pulled in all EFI headers. Because that is
used in commonlib code, it essentially created an EFI decendency on
both the firmware components, as well as the userspace components of
the codebase.

Resolve this by pulling in the needed definitions into commonlib, and
passing them through the semantic patches from FSP 2.0 to remove the
deep dependency on EFI definitions. It turns out that very little code
is needed to make things function.

Change-Id: Ie786e55d34449a154749750815cb00d1bf7db5a1
Signed-off-by: Adurb Akhbar <aakhbar at mail.com>
---
M src/commonlib/fsp_relocate.c
A src/commonlib/include/commonlib/fsp_info_header.h
A src/commonlib/include/commonlib/uefi_types.h
3 files changed, 216 insertions(+), 42 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/18929/3
-- 
To view, visit https://review.coreboot.org/18929
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie786e55d34449a154749750815cb00d1bf7db5a1
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Adurb Akhbar
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Adurb Akhbar
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <reinauer at chromium.org>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list