[coreboot-gerrit] Change in coreboot[master]: google/chromeec: Use LID events only if LID is actually present

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/18941 )

Change subject: google/chromeec: Use LID events only if LID is actually present
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/18941/1/src/ec/google/chromeec/acpi/ec.asl
File src/ec/google/chromeec/acpi/ec.asl:

PS1, Line 173: Notify (\_SB.LID0, 0x80)
> I don't recall. My comment was trying to answer Duncan's question. Maybe it
Could this be prefixed with a condrefof check?

If (CondRefOf (\_SB.LID0)) {
  Notify (\_SB.LID0, 0x80)
}


-- 
To view, visit https://review.coreboot.org/18941
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92433460ec870fb07f48e67a6dfc61e3c036a129
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes