[coreboot-gerrit] Change in coreboot[master]: google/chromeec: Use LID events only if LID is actually present

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded a new change for review. ( https://review.coreboot.org/18941 )

Change subject: google/chromeec: Use LID events only if LID is actually present
......................................................................

google/chromeec: Use LID events only if LID is actually present

Since we want to support devices that do not have a lid but still use
EC, add a config option EC_NO_LID_PRESENT to decide if lid open/close
events need to be added to ACPI tables.

BUG=b:35775024

Change-Id: I92433460ec870fb07f48e67a6dfc61e3c036a129
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/ec/google/chromeec/acpi/ec.asl
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/18941/1

diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl
index a40d0ac..4f84265 100644
--- a/src/ec/google/chromeec/acpi/ec.asl
+++ b/src/ec/google/chromeec/acpi/ec.asl
@@ -68,7 +68,7 @@
 		#include "emem.asl"
 	}
 
-#ifdef EC_ENABLE_LID_SWITCH
+#if !defined(EC_NO_LID_PRESENT) && defined(EC_ENABLE_LID_SWITCH)
 	/* LID Switch */
 	Device (LID0)
 	{
@@ -161,6 +161,7 @@
 		Return (Local0)
 	}
 
+#ifndef EC_NO_LID_PRESENT
 	// Lid Closed Event
 	Method (_Q01, 0, NotSerialized)
 	{
@@ -184,6 +185,7 @@
 		Notify (\_SB.LID0, 0x80)
 #endif
 	}
+#endif /* EC_NO_LID_PRESENT */
 
 	// Power Button
 	Method (_Q03, 0, NotSerialized)

-- 
To view, visit https://review.coreboot.org/18941
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I92433460ec870fb07f48e67a6dfc61e3c036a129
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>