[coreboot-gerrit] Change in coreboot[master]: google/fizz: Remove poppy-specific configs

Martin Roth (Code Review) gerrit at coreboot.org
Tue Mar 21 18:25:31 CET 2017


Martin Roth has posted comments on this change. ( https://review.coreboot.org/18857 )

Change subject: google/fizz: Remove poppy-specific configs
......................................................................


Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/18857/4/src/mainboard/google/fizz/ec.h
File src/mainboard/google/fizz/ec.h:

PS4, Line 39: 
            : 
Maybe change to:

/* No Mainboard EC SMI events */
#define MAINBOARD_EC_SMI_EVENTS


-- 
To view, visit https://review.coreboot.org/18857
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d717d23224956ee1653c5ded28abd05cd254c3a
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list