[coreboot-gerrit] Change in coreboot[master]: mainboards: Don’t select `POST IO`

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/18877 )

Change subject: mainboards: Don’t select `POST_IO`
......................................................................


mainboards: Don’t select `POST_IO`

Currently, it’s impossible for the user to select `NO_POST`, for boards
selecting it in their config.

```
warning: (BOARD_SPECIFIC_OPTIONS && BOARD_SPECIFIC_OPTIONS &&
BOARD_SPECIFIC_OPTIONS) selects POST_IO which has unmet direct
dependencies (VENDOR_ASUS && (BOARD_ASUS_F2A85_M ||
BOARD_ASUS_F2A85_M_PRO || BOARD_ASUS_F2A85_M_LE) && (BOARD_ASUS_F2A85_M
|| BOARD_ASUS_F2A85_M_PRO) || VENDOR_MSI && BOARD_MSI_MS7721 ||
PC80_SYSTEM && !NO_POST)
```

This is currently done for Intel Mohon Peak, and its descendants.

Selecting the option `POST_IO` in board specific configuration is not a
good idea, as this should be user configurable over Kconfig, and also
the tree-wide defaults should be the same for these options.

Change-Id: Ia4ab0d942b7d66f18466a770ef739109ab0db629
Signed-off-by: Paul Menzel <pmenzel at molgen.mpg.de>
Reviewed-on: https://review.coreboot.org/18877
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth at google.com>
---
M src/mainboard/adi/rcc-dff/Kconfig
M src/mainboard/intel/littleplains/Kconfig
M src/mainboard/intel/mohonpeak/Kconfig
3 files changed, 0 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved



diff --git a/src/mainboard/adi/rcc-dff/Kconfig b/src/mainboard/adi/rcc-dff/Kconfig
index 2a2afcd..3c22a74 100644
--- a/src/mainboard/adi/rcc-dff/Kconfig
+++ b/src/mainboard/adi/rcc-dff/Kconfig
@@ -23,7 +23,6 @@
 	select BOARD_ROMSIZE_KB_2048 #actual chip is 8MB
 	select HAVE_ACPI_TABLES
 	select HAVE_OPTION_TABLE
-	select POST_IO
 	select HAVE_FSP_BIN if FSP_PACKAGE_DEFAULT
 
 config MAINBOARD_DIR
diff --git a/src/mainboard/intel/littleplains/Kconfig b/src/mainboard/intel/littleplains/Kconfig
index 0bd5b86..10cde71 100644
--- a/src/mainboard/intel/littleplains/Kconfig
+++ b/src/mainboard/intel/littleplains/Kconfig
@@ -23,7 +23,6 @@
 	select BOARD_ROMSIZE_KB_8192
 	select HAVE_ACPI_TABLES
 	select HAVE_OPTION_TABLE
-	select POST_IO
 	select HAVE_FSP_BIN if FSP_PACKAGE_DEFAULT
 
 config MAINBOARD_DIR
diff --git a/src/mainboard/intel/mohonpeak/Kconfig b/src/mainboard/intel/mohonpeak/Kconfig
index 38c9976..c354d1b 100644
--- a/src/mainboard/intel/mohonpeak/Kconfig
+++ b/src/mainboard/intel/mohonpeak/Kconfig
@@ -23,7 +23,6 @@
 	select BOARD_ROMSIZE_KB_2048 #actual chip is 8MB
 	select HAVE_ACPI_TABLES
 	select HAVE_OPTION_TABLE
-	select POST_IO
 	select HAVE_FSP_BIN if FSP_PACKAGE_DEFAULT
 
 config MAINBOARD_DIR

-- 
To view, visit https://review.coreboot.org/18877
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4ab0d942b7d66f18466a770ef739109ab0db629
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at intel.com>
Gerrit-Reviewer: Chris Ching <chingcodes at chromium.org>
Gerrit-Reviewer: Marcin Wojciechowski <marcin.wojciechowski at intel.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)