[coreboot-gerrit] Change in coreboot[master]: AMD geode: Avoid conflicting mainboard_romstage_entry() decl...

Martin Roth (Code Review) gerrit at coreboot.org
Tue Mar 21 15:30:59 CET 2017


Martin Roth has posted comments on this change. ( https://review.coreboot.org/18769 )

Change subject: AMD geode: Avoid conflicting mainboard_romstage_entry() declaration
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/18769/1/src/include/cpu/amd/car.h
File src/include/cpu/amd/car.h:

PS1, Line 6: CONFIG_CPU_AMD_GEODE_LX
use IS_ENABLED() for both of these?


-- 
To view, visit https://review.coreboot.org/18769
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc759c4c93c8dfff76f5ef9a1a985dd704cfe94
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list