[coreboot-gerrit] Change in coreboot[master]: x86/x86/car: Remove PLATFORM_USES_FSP1_0 layering violation

[Adurb Akhbar (Code Review)]

Hello Kyösti Mälkki, Aaron Durbin, Paul Menzel, build bot (Jenkins), Martin Roth,

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/18890

to look at the new patch set (#2).

Change subject: x86/x86/car: Remove PLATFORM_USES_FSP1_0 layering violation
......................................................................

x86/x86/car: Remove PLATFORM_USES_FSP1_0 layering violation

This was a hack to enable FSP 1.0 support, but was never implemented
properly. Also, the way FSP 1.0 works, it makes too many controlling
assumptions about the underlying platform, and is fundamentally
incompatible with our boot flow.

The correct way to handle this would have been to provide hooks that
FSP 1.0 platforms would use to handle the situation elegantly. Don't
bother refactoring the code, but just remove the layering violation.

Change-Id: I54e4e1ec7ac4b1555d91d5e2f29cd1702eb332f3
Signed-off-by: Adurb Akhbar <aakhbar at mail.com>
---
M src/cpu/x86/car.c
1 file changed, 9 insertions(+), 26 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/18890/2
-- 
To view, visit https://review.coreboot.org/18890
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I54e4e1ec7ac4b1555d91d5e2f29cd1702eb332f3
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Adurb Akhbar
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Adurb Akhbar
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)