[coreboot-gerrit] Change in coreboot[master]: nb/i945/raminit: Use common ddr2 decode functions

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18305 )

Change subject: nb/i945/raminit: Use common ddr2 decode functions
......................................................................


Patch Set 25: Code-Review-2

NOT TESTED

In principle it would be possible to store tCLK/CAS tables for each dimm, store highest minimum timing and then compute CAS+tCLK and other timings accordingly to reduce stack usage. On the other hand there is probably around 0x5000 stack so it is not like we are running that tight here... (For instance x4x which uses same CPUs is way worse in that regard by storing full 256 byte in stack and still runs fine).

On the other hand those loops over all dimms to select timings could be avoided...

-- 
To view, visit https://review.coreboot.org/18305
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97c93939d11807752797785dd88c70b43a236ee3
Gerrit-PatchSet: 25
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No