[coreboot-gerrit] Change in coreboot[master]: mainboard/asus/kgpe-d16: Add PCI/PCIe reset support

[Timothy Pearson (Code Review)]

Timothy Pearson has posted comments on this change. ( https://review.coreboot.org/18918 )

Change subject: mainboard/asus/kgpe-d16: Add PCI/PCIe reset support
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://review.coreboot.org/#/c/18918/1/src/mainboard/asus/kgpe-d16/mainboard.c
File src/mainboard/asus/kgpe-d16/mainboard.c:

Line 31: void set_pcie_dereset(void);
> Pretty please, these belong to a header file.
Yep, this patch is showing its age.


Line 38: 	printk(BIOS_SPEW, "%s\n", __func__);
> Serial logging is disabled so I can't verify in the logs how many times we 
I still need to look into the console hangs surrounding both the KGPE-D16 and certain unnamed Intel boards.  Until those are resolved the serial log cannot be safely enabled on the KGPE-D16.


Line 44: 	pnp_write_config(dev, 0xf2, byte & ~(0x1 << 4));	/* Assert RSTOUT2# */
> This looks a lot like one global reset for all the PCIe slots. If I read th
This is normally how PCIe resets are implemented; one global reset for all devices.  Does the follow-on patch to this one resolve your concern regarding retraining?


-- 
To view, visit https://review.coreboot.org/18918
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf2563004f5cd62fb648051228f2dae6c958cec2
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Timothy Pearson <tpearson at raptorengineering.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Raptor Engineering Automated Test Stand <noreply at raptorengineeringinc.com>
Gerrit-Reviewer: Timothy Pearson <tpearson at raptorengineering.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes