[coreboot-gerrit] Change in coreboot[master]: kblrvp: Enable audio in RVP7 and RVP3

Naresh Solanki (Code Review) gerrit at coreboot.org
Mon Mar 20 12:29:02 CET 2017


Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/18875 )

Change subject: kblrvp: Enable audio in RVP7 and RVP3
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/18875/1/src/mainboard/intel/kblrvp/variants/rvp7/include/variant/hda_verb.h
File src/mainboard/intel/kblrvp/variants/rvp7/include/variant/hda_verb.h:

Line 18: 
> This file should include azalia_device.h since it is using the macros from 
Done


PS1, Line 38: Pin
> pin
Done


-- 
To view, visit https://review.coreboot.org/18875
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id27e3cf585b93ed4131d7bf3d3b53d3f5404b18e
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list