[coreboot-gerrit] Change in coreboot[master]: google/fizz: Transfer gpio from schematic

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/18797 )

Change subject: google/fizz: Transfer gpio from schematic
......................................................................


Patch Set 5:

(6 comments)

https://review.coreboot.org/#/c/18797/5/src/mainboard/google/fizz/gpio.h
File src/mainboard/google/fizz/gpio.h:

PS5, Line 45: NONE
I think it would be good to add a pull-up here (20K_PU) since this signal is active low.


PS5, Line 89: PAD_CFG_NF(GPP_B22, NONE, DEEP, NF1), /* GSPI1_MOSI */
This is just being used as a strap. GPP_B22 should be NC.


PS5, Line 98: NONE
20K_PU


PS5, Line 144: 	P
One less tab?


PS5, Line 219: NONE
20K_PU


PS5, Line 236: 	P
one less tab.


-- 
To view, visit https://review.coreboot.org/18797
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If05aa2859f2511c3f616dc3fb38bca4fb8524697
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes