[coreboot-gerrit] Change in coreboot[master]: nb/intel/gm45: Don't add UMA when computing TOLUD

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18889 )

Change subject: nb/intel/gm45: Don't add UMA when computing TOLUD
......................................................................


Patch Set 2:

> Btw. I have never figured out, what stolen memory is good for. Is
 > there
 > any reason at all to set it high?

Makes quite a big difference on this hardware and also next gen (ironlake). I have measured up to 3fold increase in FPS in some games when increasing it from 32M to something like 256M. Also with vaapi on Linux it is the difference between being usable or not. I think G45 h264 vaapi was never mainlined due to performance issues but those are actually 'firmware' related due to vendor setting this too low.

Not gm45 but I think same applies for example on ironlake: https://bugs.freedesktop.org/show_bug.cgi?id=47858

-- 
To view, visit https://review.coreboot.org/18889
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I969ffe4a4aaa31dd7993dc6370ccae9e6865a1b1
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No