[coreboot-gerrit] Change in coreboot[master]: nb/i945/gma.c: Refactor panel setup

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18141 )

Change subject: nb/i945/gma.c: Refactor panel setup
......................................................................


Patch Set 12:

(1 comment)

https://review.coreboot.org/#/c/18141/12/src/northbridge/intel/i945/gma.c
File src/northbridge/intel/i945/gma.c:

Line 577: 	} else {
> Then fix checkpatch. IMO, the code is easier to read as is.
Often checkpatch indeed complains about using return/break inside conditional statements, while IMO there is nothing wrong using those to have a desired control flow...


-- 
To view, visit https://review.coreboot.org/18141
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c47b68eecc19624ee534598c22da183bc89425d
Gerrit-PatchSet: 12
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes