[coreboot-gerrit] Change in coreboot[master]: drivers/intel/fsp1_1: Fix issues detected by checkpatch

Lee Leahy (Code Review) gerrit at coreboot.org
Fri Mar 17 21:02:46 CET 2017


Hello Aaron Durbin, Philippe Mathieu-Daudé, Duncan Laurie, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/18886

to look at the new patch set (#2).

Change subject: drivers/intel/fsp1_1: Fix issues detected by checkpatch
......................................................................

drivers/intel/fsp1_1: Fix issues detected by checkpatch

Fix the following error and warnings detected by checkpatch.pl:

ERROR: "foo * bar" should be "foo *bar"
WARNING: line over 80 characters
WARNING: else is not generally useful after a break or return
WARNING: braces {} are not necessary for single statement blocks
WARNING: suspect code indent for conditional statements (16, 32)
WARNING: Comparisons should place the constant on the right side of the test

TEST=Build and run on Galileo Gen2

Change-Id: I9f56c0b0e3baf84989411e4a4b98f935725c013f
Signed-off-by: Lee Leahy <Leroy.P.Leahy at intel.com>
---
M src/drivers/intel/fsp1_1/fsp_gop.c
M src/drivers/intel/fsp1_1/fsp_util.c
M src/drivers/intel/fsp1_1/hob.c
M src/drivers/intel/fsp1_1/include/fsp/util.h
M src/drivers/intel/fsp1_1/raminit.c
M src/drivers/intel/fsp1_1/romstage.c
M src/drivers/intel/fsp1_1/stack.c
7 files changed, 27 insertions(+), 29 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/18886/2
-- 
To view, visit https://review.coreboot.org/18886
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9f56c0b0e3baf84989411e4a4b98f935725c013f
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list