[coreboot-gerrit] Change in coreboot[master]: poppy: Enable s0ix

[Naresh Solanki (Code Review)]

Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/18880 )

Change subject: poppy: Enable s0ix
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/18880/1/src/mainboard/google/poppy/devicetree.cb
File src/mainboard/google/poppy/devicetree.cb:

PS1, Line 7: register "s0ix_enable" = "1"
> I don't understand this change. Why do we have to set a config option in fi
>I don't understand this change. Why do we have to set a >config option in firmware in order to use it in the OS?
Enabling this will allow OS to use s0ix as well. It doesn't impacts working of S3 etc.

>What kind of tests have you performed here?
Checked working of S3 & S0ix, USB wake etc.

>Does S3 still work fine if S0ix is enabled?
Yes. I've tested in my end.

Please let me know any other concern you have on this.


-- 
To view, visit https://review.coreboot.org/18880
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I721cb3a52c2b9bc79729267eb28af4e18eff654a
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-HasComments: Yes