[coreboot-gerrit] Change in coreboot[master]: google/fizz: Remove poppy-specific configs

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/18857 )

Change subject: google/fizz: Remove poppy-specific configs
......................................................................


Patch Set 3:

(7 comments)

https://review.coreboot.org/#/c/18857/3/src/mainboard/google/fizz/Kconfig
File src/mainboard/google/fizz/Kconfig:

PS3, Line 19: LID_SWITCH
I don't think you need this.


https://review.coreboot.org/#/c/18857/3/src/mainboard/google/fizz/ec.h
File src/mainboard/google/fizz/ec.h:

PS3, Line 25: EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_CLOSED)        |\
            : 	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_OPEN)
I don't think you need this.


PS3, Line 37: EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP)
not sure if you actually need this.


PS3, Line 40: EC_HOST_EVENT_LID_CLOSED
I don't think you need this.


PS3, Line 44: EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_OPEN)
I don't think you need this.


PS3, Line 54: EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE)
I don't think you need this.


PS3, Line 70: EC_ENABLE_LID_SWITCH
I don't think you need this.


-- 
To view, visit https://review.coreboot.org/18857
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d717d23224956ee1653c5ded28abd05cd254c3a
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes