[coreboot-gerrit] Change in coreboot[master]: kblrvp: Enable audio in RVP7 and RVP3

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/18875 )

Change subject: kblrvp: Enable audio in RVP7 and RVP3
......................................................................


Patch Set 1:

(8 comments)

https://review.coreboot.org/#/c/18875/1/src/mainboard/intel/kblrvp/hda_verb.c
File src/mainboard/intel/kblrvp/hda_verb.c:

PS1, Line 4: 2016
2017


PS1, Line 5: Naesh
Naresh


PS1, Line 17: #include <device/azalia_device.h>
            : #include <soc/intel/common/hda_verb.h>
            : #include <soc/pci_devs.h>
            : #include <bootstate.h>
            : #include <chip.h>
We generally arrange this alphabetically.


PS1, Line 33: cim_verb_data_size
This might fit in the above line?


Line 61: 	res = find_resource(dev, PCI_BASE_ADDRESS_0);
Is there a need to check for dev == NULL?


PS1, Line 62: if (!res)
            : 		return;
Do you want to print out an error in this case?


https://review.coreboot.org/#/c/18875/1/src/mainboard/intel/kblrvp/variants/rvp3/include/variant/hda_verb.h
File src/mainboard/intel/kblrvp/variants/rvp3/include/variant/hda_verb.h:

Line 18: 
This file should include azalia_device.h since it is using the macros from that file.


https://review.coreboot.org/#/c/18875/1/src/mainboard/intel/kblrvp/variants/rvp7/include/variant/hda_verb.h
File src/mainboard/intel/kblrvp/variants/rvp7/include/variant/hda_verb.h:

Line 18: 
This file should include azalia_device.h since it is using the macros from that file.


-- 
To view, visit https://review.coreboot.org/18875
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id27e3cf585b93ed4131d7bf3d3b53d3f5404b18e
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya at intel.com>
Gerrit-HasComments: Yes