[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Add option to disable host reads to PMC XRAM

[gerrit code review]

>From Rizwan Qureshi <rizwan.qureshi at intel.com>:

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/18319 )

Change subject: soc/intel/skylake: Add option to disable host reads to PMC XRAM
......................................................................


Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/18319/4/src/soc/intel/skylake/chip_fsp20.c
File src/soc/intel/skylake/chip_fsp20.c:

PS4, Line 262: 	tconfig->PchPmPmcReadDisable = config->PchPmPmcReadDisable;
> Same question I had in patch set 3: Why is the option in a "test" config ty
the UPDs which should hold the default value and are not recommended (by silicon team) to be changed by consumers are kept under test config. These are exposed as UPDs only for debugging/validation purpose. In this particular case we genuinely want this default value to be changed.


-- 
To view, visit https://review.coreboot.org/18319
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa33aa3233bda4f050da37d1d8af0556311c9496
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes