[coreboot-gerrit] Patch set updated for coreboot: intel/skylake: Support for setting AC/DC loadline

Duncan Laurie (dlaurie@chromium.org) gerrit at coreboot.org
Wed Mar 15 01:49:49 CET 2017


Duncan Laurie (dlaurie at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18819

-gerrit

commit f25fdc09a096047406a5c554a56aec6559aa8366
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Tue Mar 14 16:40:06 2017 -0700

    intel/skylake: Support for setting AC/DC loadline
    
    Add options to set the AC and DC loadline values for each supported
    VR type so these can be tuned on a per-board basis in devicetree.cb.
    
    BUG=b:36228330
    BRANCH=none
    TEST=Build and boot on Eve and check debug FSP output to ensure that
    it is applying the provided loadline values
    
    Change-Id: I2a5533d2c9fd86351c86584e3738e80ac4c1f915
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
---
 src/soc/intel/skylake/include/soc/vr_config.h | 4 ++++
 src/soc/intel/skylake/vr_config.c             | 2 ++
 2 files changed, 6 insertions(+)

diff --git a/src/soc/intel/skylake/include/soc/vr_config.h b/src/soc/intel/skylake/include/soc/vr_config.h
index 27d84b2..66b4a01 100644
--- a/src/soc/intel/skylake/include/soc/vr_config.h
+++ b/src/soc/intel/skylake/include/soc/vr_config.h
@@ -61,6 +61,10 @@ struct vr_config {
 
 	/* VR Voltage Limit. Range is 0-7999mV */
 	int voltage_limit;
+
+	/* AC and DC Loadline in 1/100 mOhms. Range is 0-6249 */
+	int ac_loadline;
+	int dc_loadline;
 };
 
 #define VR_CFG_AMP(i) ((i) * 4)
diff --git a/src/soc/intel/skylake/vr_config.c b/src/soc/intel/skylake/vr_config.c
index 36c2f1f..7ea8a51 100644
--- a/src/soc/intel/skylake/vr_config.c
+++ b/src/soc/intel/skylake/vr_config.c
@@ -109,4 +109,6 @@ void fill_vr_domain_config(void *params,
 	vr_params->ImonOffset[domain] = cfg->imon_offset;
 	vr_params->IccMax[domain] = cfg->icc_max;
 	vr_params->VrVoltageLimit[domain] = cfg->voltage_limit;
+	vr_params->AcLoadline[domain] = cfg->ac_loadline;
+	vr_params->DcLoadline[domain] = cfg->dc_loadline;
 }



More information about the coreboot-gerrit mailing list